On 5/4/2023 5:08 PM, Krzysztof Kozlowski wrote:
On 03/05/2023 19:02, Mukesh Ojha wrote:
Move minidump specific data types and macros to a separate internal
header(qcom_minidump.h) so that it can be shared among different
Qualcomm drivers.
No, this is not internal header. You moved it to global header.
There is no reason driver internals should be exposed to other unrelated
subsystems.
There is no change in functional behavior after this.
It is. You made all these internal symbols available to others.
This comes without justification why other drivers needs to access
private and internal data. It does not look correct design. NAK.
Thanks for catching outdated commit text, will fix the commit with
more descriptive reasoning.
It has to be global so that co-processor minidump and apss minidump can
share data structure and they are lying in different directory.
-Mukesh
Best regards,
Krzysztof
