Re: [PATCH v3] remoteproc: remove unnecessary (void*) conversions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Yu Zhe <yuzhe@xxxxxxxxxxxx>
Subject: Re: [PATCH v3] remoteproc: remove unnecessary (void*) conversions
From: Dan Carpenter <error27@xxxxxxxxx>
Date: Tue, 28 Mar 2023 10:40:04 +0300
Cc: andersson@xxxxxxxxxx, mathieu.poirier@xxxxxxxxxx, matthias.bgg@xxxxxxxxx, angelogioacchino.delregno@xxxxxxxxxxxxx, agross@xxxxxxxxxx, konrad.dybcio@xxxxxxxxxx, mcoquelin.stm32@xxxxxxxxx, alexandre.torgue@xxxxxxxxxxx, linux-remoteproc@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-mediatek@xxxxxxxxxxxxxxxxxxx, linux-arm-msm@xxxxxxxxxxxxxxx, linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx, liqiong@xxxxxxxxxxxx
In-reply-to: <20230328015749.1608-1-yuzhe@nfschina.com>
References: <20230320061157.29660-1-yuzhe@nfschina.com> <20230328015749.1608-1-yuzhe@nfschina.com>

On Tue, Mar 28, 2023 at 09:57:49AM +0800, Yu Zhe wrote:
>  static void devm_rproc_free(struct device *dev, void *res)
>  {
> -	rproc_free(*(struct rproc **)res);
> +	rproc_free(res);

This introduces a bug.

regards,
dan carpenter

References:
- [PATCH v2] remoteproc: remove unnecessary (void*) conversions
  - From: Yu Zhe
- [PATCH v3] remoteproc: remove unnecessary (void*) conversions
  - From: Yu Zhe

Prev by Date: Re: [PATCH] dt-bindings: remoteproc: Drop unneeded quotes
Next by Date: Re: [PATCH v4] remoteproc: remove unnecessary (void*) conversions
Previous by thread: Re: [PATCH v4] remoteproc: remove unnecessary (void*) conversions
Next by thread: [PATCH net-next v8] wwan: core: Support slicing in port TX flow of WWAN subsystem
Index(es):
- Date
- Thread

[Index of Archives] [Linux Sound] [ALSA Users] [ALSA Devel] [Linux Audio Users] [Linux Media] [Kernel] [Photo Sharing] [Gimp] [Yosemite News] [Linux Media]

Powered by Linux