On 12/01/2023 21:26, Matti Lehtimäki wrote: > Adds support for platforms with only single power domain. Add https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > Adds support for external power block headswitch (BHS) registers Add. Full stop. > > Signed-off-by: Matti Lehtimäki <matti.lehtimaki@xxxxxxxxx> > --- > .../remoteproc/qcom,msm8916-mss-pil.yaml | 41 +++++++++++++++++-- > 1 file changed, 37 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml > index 6e6e69ad9cd7..6a921f2711b2 100644 > --- a/Documentation/devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml > @@ -17,6 +17,7 @@ properties: > compatible: > oneOf: > - enum: > + - qcom,msm8226-mss-pil > - qcom,msm8909-mss-pil > - qcom,msm8916-mss-pil > - qcom,msm8953-mss-pil > @@ -70,16 +71,17 @@ properties: > items: > - description: CX proxy power domain (control handed over after startup) > - description: MX proxy power domain (control handed over after startup) > + (not valid for qcom,msm8226-mss-pil) > - description: MSS proxy power domain (control handed over after startup) > (only valid for qcom,msm8953-mss-pil) > - minItems: 2 > + minItems: 1 > > power-domain-names: > items: > - const: cx > - - const: mx > + - const: mx # not valid for qcom,msm8226-mss-pil > - const: mss # only valid for qcom,msm8953-mss-pil > - minItems: 2 > + minItems: 1 > > pll-supply: > description: PLL proxy supply (control handed over after startup) > @@ -106,6 +108,15 @@ properties: > items: > - const: stop > > + qcom,ext-bhs-reg: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + description: External power block headswitch (BHS) register > + (only valid for qcom,msm8226-mss-pil) > + items: > + - items: > + - description: phandle to external BHS syscon region > + - description: offset to the external BHS register > + > qcom,halt-regs: > $ref: /schemas/types.yaml#/definitions/phandle-array > description: > @@ -205,13 +216,35 @@ allOf: in this block: qcom,ext-bhs-reg: false > required: > - power-domains > - power-domain-names > - else: > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,msm8909-mss-pil > + - qcom,msm8916-mss-pil > + - qcom,msm8974-mss-pil > + then: > properties: > power-domains: > maxItems: 2 > power-domain-names: > maxItems: 2 qcom,ext-bhs-reg: false > > + - if: > + properties: > + compatible: > + const: qcom,msm8226-mss-pil > + then: > + properties: > + power-domains: > + maxItems: 1 > + power-domain-names: > + maxItems: 1 > + required: > + - qcom,ext-bhs-reg > + > - if: > properties: > compatible: Best regards, Krzysztof
