Re: [PATCH v2] remoteproc: virtio: Fix warning on bindings by removing the of_match_table

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/10/22 10:13, Arnaud Pouliquen wrote:
The checkpatch tool complains that "virtio,rproc" is not documented.
But it is not possible to probe the device "rproc-virtio" by declaring
it in the device tree. So documenting it in the bindings does not make
sense.

Perhaps reworded a bit as:

  "Since it is not possible to probe the device "rproc-virtio" by
  declaring it in the device tree, documenting it in the bindings
  does not make sense."

Otherwise:
Reviewed-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>

This commit solves the checkpatch warning by suppressing the useless
of_match_table.

Suggested-by: Rob Herring <robh@xxxxxxxxxx>
Fixes: 1d7b61c06dc3 ("remoteproc: virtio: Create platform device for the remoteproc_virtio")

Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@xxxxxxxxxxx>
Reviewed-by: Rob Herring <robh@xxxxxxxxxx>

---
Updates vs previous revision:
- replace the "of_platform.h" include by "platform_device.h",
- replace "Fix-suggested-by" by "Suggested-by",
- add Rob's Reviewed-by.
---
  drivers/remoteproc/remoteproc_virtio.c | 8 +-------
  1 file changed, 1 insertion(+), 7 deletions(-)




[Index of Archives]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Photo Sharing]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux