Hi Rob, On 12/10/22 18:49, Rob Herring wrote: > On Wed, 12 Oct 2022 17:14:25 +0530, MD Danish Anwar wrote: >> From: Suman Anna <s-anna@xxxxxx> >> >> Add a YAML binding document for PRU consumers. The binding includes >> all the common properties that can be used by different PRU consumer >> or application nodes and supported by the PRU remoteproc driver. >> These are used to configure the PRU hardware for specific user >> applications. >> >> The application nodes themselves should define their own bindings. >> >> Co-developed-by: Tero Kristo <t-kristo@xxxxxx> >> Signed-off-by: Tero Kristo <t-kristo@xxxxxx> >> Signed-off-by: Suman Anna <s-anna@xxxxxx> >> Co-developed-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@xxxxxxxxxx> >> Signed-off-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@xxxxxxxxxx> >> Signed-off-by: Puranjay Mohan <p-mohan@xxxxxx> >> Signed-off-by: MD Danish Anwar <danishanwar@xxxxxx> >> --- >> .../bindings/remoteproc/ti,pru-consumer.yaml | 132 ++++++++++++++++++ >> 1 file changed, 132 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.example.dtb:0:0: /example-0/icssg2-eth: failed to match any schema with compatible: ['ti,am654-icssg-prueth'] > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/patch/ > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > This error is coming as this dt-schema has 'ti,am654-icssg-prueth' as compatible in the example section, which is introduced in [1] patch series. Including the full example section in this dt schema binding is causing this error. In v5 [2] of this series, only the 'ti,prus', 'firmware-name' and 'ti,pruss-gp-mux-sel' properties were included in the example section. Mathieu had asked to include full example in the dt binding document. So I added full example section. But in full example I included compatible property as well which is not introduced in this series thus creating dt check binding error. I will remove the example section from here and add it to dt-schema binding of icssg-prueth. [1] https://lore.kernel.org/all/20220531095108.21757-2-p-mohan@xxxxxx/ [2] https://lore.kernel.org/all/20220607045650.4999-2-p-mohan@xxxxxx/ > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. >
