On Sun, Oct 09, 2022 at 05:23:06PM +0200, Krzysztof Kozlowski wrote: > On 08/10/2022 23:11, David Laight wrote: > >>> --- > >>> drivers/rpmsg/qcom_glink_native.c | 2 +- > >>> drivers/rpmsg/qcom_smd.c | 4 ++-- > >>> 2 files changed, 3 insertions(+), 3 deletions(-) > >> > >> Why just this specific kernel branch? We can't add patches to an older > >> tree and have someone upgrade to a newer one and hit the same issue. > >> > >> So please provide backports for all active versions. In this case that > >> would be 5.15.y and 5.19.y. > > > > If it is only fixing a compile warning is it even stable material? > > The generic commit message doesn't say whether the old code was > > actually right or wrong. > > > > At least one of these 'replace strncpy()' changes was definitely > > broken (the copy needed to be equivalent to memcpy()). > > > > So applying ANY of them to stable unless they actually fix > > a real bug seems dubious. > > Except the warning from GCC, there was no bug to fix. The warning is > about discouraged and risky practice, but no actual real risk was > identified, so for me it matches stable rules poorly. > > It's basically backporting to silence automated code checkers... Are you sure? Look at the code path here, there might be a way to overflow the string, from the virtio interface, but I might be wrong... Anyway, I need all the backports before I can take this one, sorry. greg k-h
