Re: [PATCH V3 0/3] rpmsg signaling/flowcontrol patches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Deepak,

On 9/14/22 07:24, Deepak Kumar Singh wrote:
> [Changes from V2]:
> Trivial review comment fixes.
> Avoid TIOCM_DTR etc signals in glink layer, use native signal macros only.
> Glink layer to provide only flowcontrol on/off interface, no specific signal passing/receiving to client.


Please, could you have a look to my series that implements
your proposed interface for the virtio rpmsg [1]?
It would be nice that your API takes into account update to
support of the rpmsg virtio implementation proposed in [08/10] rpmsg: Add the
destination address in rpmsg_set_flow_control[2]

Thanks,
Arnaud

[1] https://lore.kernel.org/lkml/e54bcfcb-8e37-9caa-b330-a7411820b7ce@xxxxxxxxxxx/T/
[2]https://lore.kernel.org/lkml/e54bcfcb-8e37-9caa-b330-a7411820b7ce@xxxxxxxxxxx/T/#m7340a8e70fb0d8935869c4cef96863abda555c96

> 
> Deepak Kumar Singh (3):
>   rpmsg: core: Add signal API support
>   rpmsg: glink: Add support to handle signals command
>   rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support
> 
>  drivers/rpmsg/qcom_glink_native.c | 63 +++++++++++++++++++++++++++++++++++++++
>  drivers/rpmsg/rpmsg_char.c        | 60 ++++++++++++++++++++++++++++++++-----
>  drivers/rpmsg/rpmsg_core.c        | 20 +++++++++++++
>  drivers/rpmsg/rpmsg_internal.h    |  2 ++
>  include/linux/rpmsg.h             | 15 ++++++++++
>  5 files changed, 152 insertions(+), 8 deletions(-)
> 



[Index of Archives]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Photo Sharing]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux