On Fri Sep 9, 2022 at 1:30 PM IST, Krzysztof Kozlowski wrote: > On 08/09/2022 20:49, Sireesh Kodali wrote: > > The qcom,pronto compatible is used in the wcn36xx driver to determine > > which register to access. However, this compatible was not documented. > > This patch documents the existing compatible as is, since it isn't > > immediately clear why the wcn36xx driver uses this extra compatible, > > rather than relying directly on the regular compatible string. > > The patch does much more - messes entirely all compatibles... Is there another preferred way to handle this? > > > > > Signed-off-by: Sireesh Kodali <sireeshkodali1@xxxxxxxxx> > > --- > > .../bindings/remoteproc/qcom,wcnss-pil.yaml | 16 ++++++++++++---- > > 1 file changed, 12 insertions(+), 4 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml > > index bc18139fdb91..5e4a97e9d330 100644 > > --- a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml > > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml > > @@ -15,10 +15,18 @@ description: > > > > properties: > > compatible: > > - enum: > > - - qcom,riva-pil > > - - qcom,pronto-v1-pil > > - - qcom,pronto-v2-pil > > + description: > > + Append "qcom,pronto" if the device is actually pronto, and not riva > > + oneOf: > > + - items: > > + - enum: > > + - qcom,pronto-v1-pil > > + - qcom,pronto-v2-pil > > + - enum: > > + - qcom,pronto > > It's const, not enum. > > > + - items: > > No items. Both these things will be fixed in v3 > > > + - enum: > > + - qcom,riva-pil > > > Best regards, > Krzysztof
