On 08/09/2022 20:24, Stephan Gerhold wrote: > qcom,q6v5.txt covers multiple SoCs with quite different binding > requirements. Converting this into one DT schema would require > several if statements, making the DT schema overall harder to > read and understand. > > To avoid this, follow the example of SC7180/SC7280 and split > "qcom,msm8916-mss-pil" (and the equivalent deprecated "qcom,q6v5-pil" > compatible) into a separate DT schema. The schema is somewhat based > on the one for SC7180/SC7280 but adjusted for the old platforms. > > Compared to the old plain text bindings, add missing documentation for > the "bam-dmux" subnode and recommend one particular approach to specify > the MBA/MPSS "memory-region" (the other one is marked as deprecated). > > Signed-off-by: Stephan Gerhold <stephan.gerhold@xxxxxxxxxxxxxxx> > --- > "dt-bindings: remoteproc: qcom,smd-edge: Add APR/FastRPC" [1] should be > applied additionally to avoid a dtbs_check warning related to fastrpc in > msm8916.dtsi. > > Changes in v4: Add "unevaluatedProperties: false" to smd-edge > Changes in v3: None > Changes in v2: > - Add blank lines between top-level properties > - Drop "deprecated" in "oneOf" list, it is not clear if this is valid > and it should be redundant since the properties itself are already > marked as "deprecated" > > [1]: https://lore.kernel.org/linux-arm-msm/20220908181432.458900-1-stephan.gerhold@xxxxxxxxxxxxxxx/ Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof
