On 06/09/2022 11:03, Krzysztof Kozlowski wrote: > On 31/08/2022 15:46, Stephan Gerhold wrote: > > Thank you for your patch. There is something to discuss/improve. > >> + qcom,halt-regs: >> + $ref: /schemas/types.yaml#/definitions/phandle-array >> + description: >> + Halt registers are used to halt transactions of various sub-components >> + within MSS. >> + items: >> + - items: >> + - description: phandle to TCSR syscon region >> + - description: offset to the Q6 halt register >> + - description: offset to the modem halt register >> + - description: offset to the nc halt register >> + >> + memory-region: >> + items: >> + - description: MBA reserved region >> + - description: MPSS reserved region >> + >> + firmware-name: >> + $ref: /schemas/types.yaml#/definitions/string-array >> + items: >> + - description: Name of MBA firmware >> + - description: Name of modem firmware >> + >> + bam-dmux: >> + $ref: /schemas/net/qcom,bam-dmux.yaml# >> + description: >> + Qualcomm BAM Data Multiplexer (provides network interface to the modem) >> + >> + smd-edge: >> + $ref: qcom,smd-edge.yaml# >> + description: >> + Qualcomm SMD subnode which represents communication edge, channels >> + and devices related to the DSP. >> + >> + properties: >> + label: >> + enum: >> + - modem >> + - hexagon > > This needs unevaluatedProperties:false. I will fix qcom,adsp.yaml which > has similar problem. ... which might point to several warnings in all audio schemas. I am working to fix these. Best regards, Krzysztof
