On 14/07/2022 21:01, Stephan Gerhold wrote:
> On Thu, Jul 14, 2022 at 11:55:44AM +0200, Krzysztof Kozlowski wrote:
>> On 12/07/2022 14:44, Stephan Gerhold wrote:
>>> The remoteproc configuration in qcom-msm8974.dtsi is incomplete because
>>>
>>> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
>>> index 814ad0b46232..35246bd02132 100644
>>> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
>>> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
>>> @@ -1172,6 +1172,8 @@ remoteproc_mss: remoteproc@fc880000 {
>>> qcom,smem-states = <&modem_smp2p_out 0>;
>>> qcom,smem-state-names = "stop";
>>>
>>> + status = "disabled";
>>> +
>>> mba {
>>> memory-region = <&mba_region>;
>>> };
>>> @@ -1639,6 +1641,8 @@ remoteproc_adsp: remoteproc@fe200000 {
>>> qcom,smem-states = <&adsp_smp2p_out 0>;
>>> qcom,smem-state-names = "stop";
>>>
>>> + status = "disabled";
>>> +
>>> smd-edge {
>>> interrupts = <GIC_SPI 156 IRQ_TYPE_EDGE_RISING>;
>>>
>>> diff --git a/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts b/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts
>>> index 58cb2ce1e4df..8a6b8e4de887 100644
>>> --- a/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts
>>> +++ b/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts
>>> @@ -147,10 +147,12 @@ wcnss {
>>> };
>>>
>>> &remoteproc_adsp {
>>> + status = "okay";
>>
>> These go to the end of properties.
>>
>
> All the other nodes in these two files have the 'status = "okay"' at the
> beginning (just like most of the Qualcomm boards actually). I know there
> have been some discussion to change this, but until existing boards have
> been changed I would rather not introduce a wild mix of both approaches
> (within the same file at least).
I would say less code to fix later, but OK.
Best regards,
Krzysztof
