On Thu, Jul 14, 2022 at 11:50:30AM +0200, Krzysztof Kozlowski wrote:
> On 12/07/2022 14:44, Stephan Gerhold wrote:
> > [...]
> > +properties:
> > + compatible:
> > + oneOf:
> > + - enum:
> > + - qcom,msm8916-mss-pil
> > +
> > + - const: qcom,q6v5-pil
> > + description: Deprecated, prefer using qcom,msm8916-mss-pil
> > + deprecated: true
>
> The last compatible does not seem applicable here. Aren't you moving
> only MSM8916 to new schema?
>
"qcom,q6v5-pil" is exactly the same as "qcom,msm8916-mss-pil". It's just
a deprecated quite unfortunately chosen old name for the same thing. :)
See these lines in the driver:
{ .compatible = "qcom,q6v5-pil", .data = &msm8916_mss},
{ .compatible = "qcom,msm8916-mss-pil", .data = &msm8916_mss},
> > [...]
> > + # Deprecated properties
> > + cx-supply:
> > + description: CX power domain regulator supply (prefer using power-domains)
> > + deprecated: true
>
> Blank line, here and in other places between top-level properties.
>
Ack, will change this in v2.
> > [...]
> > +# Fallbacks for deprecated properties
> > +allOf:
> > + - oneOf:
> > + - required:
> > + - memory-region
> > + - required:
> > + - mba
> > + - mpss
> > + deprecated: true
>
> Not sure if this is correct syntax.
>
Yeah I was not sure either but at least dt_binding_check does not
complain about this. :-)
Maybe Rob has an opinion if this makes sense or not?
Thanks,
Stephan
