On Tue, 5 Jul 2022 at 06:14, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 20/06/2022 20:37, Krzysztof Kozlowski wrote: > > On 09/06/2022 10:56, Krzysztof Kozlowski wrote: > >> On 19/05/2022 09:33, Krzysztof Kozlowski wrote: > >>> The use of strncpy() is considered deprecated for NUL-terminated > >>> strings[1]. Replace strncpy() with strscpy_pad(), to keep existing > >>> pad-behavior of strncpy, similarly to commit 08de420a8014 ("rpmsg: > >>> glink: Replace strncpy() with strscpy_pad()"). This fixes W=1 warning: > >>> > >>> In function ‘qcom_glink_rx_close’, > >>> inlined from ‘qcom_glink_work’ at ../drivers/rpmsg/qcom_glink_native.c:1638:4: > >>> drivers/rpmsg/qcom_glink_native.c:1549:17: warning: ‘strncpy’ specified bound 32 equals destination size [-Wstringop-truncation] > >>> 1549 | strncpy(chinfo.name, channel->name, sizeof(chinfo.name)); > >>> > >>> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings > >>> > >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > >>> > >>> --- > >>> > >>> Changes since v1: > >>> 1. Split series per subsystem. > >> > >> Any comments on these? > > > > I sent first iteration in May, then on 19th of May. There is review from > > Stephen. > > > > On 9th of June I pinged but the patchset is still waiting. Anyone minds > > me taking these? > > Hmmm... These are all fixes but wait for quite a long time. Shall we > make the rpmsg subsystem orphaned? Bjorn handles all Qcom patches for the remoteproc/rpmsg subsystems. > > Best regards, > Krzysztof