On 19/05/2022 02:03, Stephen Boyd wrote: > Quoting Krzysztof Kozlowski (2022-05-01 03:35:14) >> diff --git a/drivers/firmware/qcom_scm-legacy.c b/drivers/firmware/qcom_scm-legacy.c >> index 1829ba220576..7854af4abc62 100644 >> --- a/drivers/firmware/qcom_scm-legacy.c >> +++ b/drivers/firmware/qcom_scm-legacy.c >> @@ -120,6 +120,9 @@ static void __scm_legacy_do(const struct arm_smccc_args *smc, >> /** >> * scm_legacy_call() - Sends a command to the SCM and waits for the command to >> * finish processing. >> + * @dev: device >> + * @desc: descriptor structure containing arguments and return values >> + * @res: results from SMC/HVC call > > I think only SMC call is possible so drop HVC to not be confusing. Sure. Best regards, Krzysztof