On Fri, May 13, 2022 at 10:15:51AM +0200, Krzysztof Kozlowski wrote: > On 11/05/2022 21:54, Nícolas F. R. A. Prado wrote: > > Thank you for your patch. There is something to discuss/improve. > > > > > -if: > > - properties: > > - compatible: > > - enum: > > - - mediatek,mt8183-scp > > - - mediatek,mt8192-scp > > -then: > > - required: > > - - clocks > > - - clock-names > > +allOf: > > + - if: > > + properties: > > + compatible: > > + enum: > > + - mediatek,mt8183-scp > > + - mediatek,mt8192-scp > > + then: > > + required: > > + - clocks > > + - clock-names > > + > > + - if: > > + properties: > > + compatible: > > + enum: > > + - mediatek,mt8183-scp > > + - mediatek,mt8186-scp > > + then: > > + properties: > > + reg: > > + maxItems: 2 > > + reg-names: > > + maxItems: 2 > > Isn't l1tcm required on mt819x? Now it is left optional. Hi Krzysztof, actually l1tcm is optional for mt819x, as commented by Tzung-Bi on v4 [1]. So that change was intended. Thanks, Nícolas [1] https://lore.kernel.org/all/CA+Px+wXQjys8xvTSSJkLXoGp4yQnANbKWBtfuxiYi0UX6DH0jw@xxxxxxxxxxxxxx/ > > > Best regards, > Krzysztof
