Re: [PATCH] dt-bindings: remoteproc: ti: Fix the number of mailboxes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 7, 2022 at 8:17 AM Suman Anna <s-anna@xxxxxx> wrote:
>
> On 1/7/22 8:13 AM, Suman Anna wrote:
> > Hi Rob,
> >
> > On 1/6/22 9:04 PM, Rob Herring wrote:
> >> Based on the example, the TI K3 DSP and R5 have 2 mailboxes, but the schema
> >> says 1. Fix the schema.
> >
> > No, 1 is correct. The OMAP Mailbox binding uses #mbox-cells as 1 and not 0, and
> > uses a phandle as the cell-value.

That's unfortunate. Really, ti,mbox-tx/rx should have been the mbox
cells with 2 entries (rx and tx)...

>
> The following is what you get with your current patch,
>
> Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.example.dt.yaml:
> dsp@4d80800000: mboxes: [[4294967295, 4294967295]] is too short
> Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.example.dt.yaml:
> dsp@64800000: mboxes: [[4294967295, 4294967295]] is too short

Ugg, yes. What I'm working on is getting validation on dtb files to
work. That means the dts <> are lost and we have to either parse the
properties properly (look up #foo-cells) or use __fixups__ to find
unresolved phandles (the case for most examples). The latter works
most of the time except a few cases like above. So the fix here is to
add a mbox provider node to the example.

Rob



[Index of Archives]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Photo Sharing]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux