> -----Original Message----- > From: Stephen Boyd <swboyd@xxxxxxxxxxxx> > Sent: Tuesday, November 16, 2021 5:13 AM > To: Rakesh Pillai <pillair@xxxxxxxxxxxxxx>; agross@xxxxxxxxxx; > bjorn.andersson@xxxxxxxxxx; mathieu.poirier@xxxxxxxxxx; ohad@xxxxxxxxxx; > p.zabel@xxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx > Cc: linux-arm-msm@xxxxxxxxxxxxxxx; linux-remoteproc@xxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > sibis@xxxxxxxxxxxxxx; mpubbise@xxxxxxxxxxxxxx; kuabhs@xxxxxxxxxxxx > Subject: Re: [PATCH v8 3/3] remoteproc: qcom: q6v5_wpss: Add support for > sc7280 WPSS > > Quoting Rakesh Pillai (2021-11-02 06:44:33) > > diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c > b/drivers/remoteproc/qcom_q6v5_adsp.c > > index 098362e6..e2e8d33 100644 > > --- a/drivers/remoteproc/qcom_q6v5_adsp.c > > +++ b/drivers/remoteproc/qcom_q6v5_adsp.c > > @@ -435,12 +571,22 @@ static int adsp_probe(struct platform_device > *pdev) > > if (!desc) > > return -EINVAL; > > > > + firmware_name = desc->firmware_name; > > + ret = of_property_read_string(pdev->dev.of_node, "firmware- > name", > > Is this documented in the binding? If not, please add it. Hi Stephen, "firmware-name" is already documented in the bindings. Thanks, Rakesh Pillai.
