On Tue 28 Sep 08:29 CDT 2021, Alexandru Ardelean wrote: > From: Alexandru Ardelean <ardeleanalex@xxxxxxxxx> > > Even though it may be user-space's fault for this error (some application > terminated or crashed without cleaning up it's endpoint), the rpmsg > communication should not overflow the syslog with too many messages. > > A dev_warn_ratelimited() seems like a good alternative in case this can > occur. > Is there anything a user could/should do when they see this entry in their log? It doesn't look very actionable to me, should we perhaps degrade it further to just a dev_dbg()? Regards, Bjorn > Signed-off-by: Alexandru Ardelean <ardeleanalex@xxxxxxxxx> > --- > drivers/rpmsg/virtio_rpmsg_bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c > index 8e49a3bacfc7..546f0fb66f1d 100644 > --- a/drivers/rpmsg/virtio_rpmsg_bus.c > +++ b/drivers/rpmsg/virtio_rpmsg_bus.c > @@ -749,7 +749,7 @@ static int rpmsg_recv_single(struct virtproc_info *vrp, struct device *dev, > /* farewell, ept, we don't need you anymore */ > kref_put(&ept->refcount, __ept_release); > } else > - dev_warn(dev, "msg received with no recipient\n"); > + dev_warn_ratelimited(dev, "msg received with no recipient\n"); > > /* publish the real size of the buffer */ > rpmsg_sg_init(&sg, msg, vrp->buf_size); > -- > 2.31.1 >
