On 5/6/21 3:46 PM, Christophe JAILLET wrote:
> 'ret' is known to be 0 here.
> Reorder the code so that the expected error code is printed.
>
> Fixes: 6dedbd1d5443 ("remoteproc: k3-r5: Add a remoteproc driver for R5F subsystem")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
Thanks for catching the issue.
Acked-by: Suman Anna <s-anna@xxxxxx>
regards
Suman
> ---
> drivers/remoteproc/ti_k3_r5_remoteproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/ti_k3_r5_remoteproc.c b/drivers/remoteproc/ti_k3_r5_remoteproc.c
> index 5cf8d030a1f0..4104e4846dbf 100644
> --- a/drivers/remoteproc/ti_k3_r5_remoteproc.c
> +++ b/drivers/remoteproc/ti_k3_r5_remoteproc.c
> @@ -1272,9 +1272,9 @@ static int k3_r5_core_of_init(struct platform_device *pdev)
>
> core->tsp = k3_r5_core_of_get_tsp(dev, core->ti_sci);
> if (IS_ERR(core->tsp)) {
> + ret = PTR_ERR(core->tsp);
> dev_err(dev, "failed to construct ti-sci proc control, ret = %d\n",
> ret);
> - ret = PTR_ERR(core->tsp);
> goto err;
> }
>
>
