Hi Arnaud, [...] > > I started by this one and then I got carried away tested the other include... > You are right, I just don't follow her the first rule of the "submit checklist" > > "If you use a facility then #include the file that defines/declares that > facility. Don’t depend on other header files pulling in ones that you use." > > That said I just have a doubt for uapi/linux/rpmsg.h that will be include > by rpmsg.h[2], as these includes are part of the rpmsg framework API, should we > keep both, considering the rule as strict? I red the last paragraph several times I can't understand what you are trying to convey. Please rephrase, provide more context or detail exactly where you think we have a problem. Thanks, Mathieu > > [1] https://www.kernel.org/doc/html/latest/process/submit-checklist.html > [2] > https://patchwork.kernel.org/project/linux-remoteproc/patch/20210311140413.31725-3-arnaud.pouliquen@xxxxxxxxxxx/ > > Thanks, > Arnaud > > > > > Thanks, > > Mathieu > > > >> > >> #define RPMSG_DEV_MAX (MINORMASK + 1) > >> > >> -- > >> 2.17.1 > >>
