Re: [RESEND PATCH v2] remoteproc/mediatek: read IPI buffer offset from FW

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Nov 28, 2020 at 12:11 AM Mathieu Poirier
<mathieu.poirier@xxxxxxxxxx> wrote:
> On Fri, 27 Nov 2020 at 02:30, Tzung-Bi Shih <tzungbi@xxxxxxxxxx> wrote:
> > The patch breaks MTK SCP when working with legacy SCP firmware.  We're
> > aware of it and will upgrade the devices' kernel and SCP firmware
> > carefully.  Other than that, AFAICT, no other devices in the wild are
> > using this driver.
> >
>
> This is the exact same patch that you sent here [1], that I commented
> on, and that you agreed with my assessment.
>
> What do you want me to do here?  What am I missing?

Yes, this is a resend patch because only the first 2 patches in the
previous series have merged.

I agree the patch is aggressive which would break machines with old
SCP firmware.  But AFAICT, no other devices are using this driver; and
we'll take care of our devices to upgrade SCP firmware first and then
kernel drivers.  Thus, ideally, no real device breakage is expected.

Would the patch be acceptable?  Or would you suggest we consider
backward-compatible anyway (even if with the context mentioned above)?



[Index of Archives]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Photo Sharing]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux