On 10/30/20 8:57 PM, Mathieu Poirier wrote: > The state of the remote processor may have changed between the > time a call to rproc_shutdown() was made and the time it is > executed. To avoid moving forward with an operation that may > have been cancelled, recheck while holding the mutex. > > Cc: <stable@xxxxxxxxxxxxxxx> > Signed-off-by: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx> > Reviewed-by: Peng Fan <peng.fan@xxxxxxx> Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@xxxxxx> Thanks, Arnaud > --- > drivers/remoteproc/remoteproc_core.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c > index dab2c0f5caf0..e55568d1e7e2 100644 > --- a/drivers/remoteproc/remoteproc_core.c > +++ b/drivers/remoteproc/remoteproc_core.c > @@ -1857,6 +1857,9 @@ void rproc_shutdown(struct rproc *rproc) > return; > } > > + if (rproc->state != RPROC_RUNNING) > + goto out; > + > /* if the remote proc is still needed, bail out */ > if (!atomic_dec_and_test(&rproc->power)) > goto out; >
