Hi Mathieu,
I applied your series on my branch to start the review and test it.
Compiler(W=1) complains and highlights an issue.
Please find comment below.
On 10/30/20 8:57 PM, Mathieu Poirier wrote:
> Adding flags to dictate how to handle a platform driver being removed
> or the remote processor crashing while in RPROC_ATTACHED state.
>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>
> ---
> drivers/remoteproc/remoteproc_core.c | 25 +++++++++++++++++++++++++
> include/linux/remoteproc.h | 5 +++++
> 2 files changed, 30 insertions(+)
>
> diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> index 229fa2cad0bd..d024367c63e5 100644
> --- a/drivers/remoteproc/remoteproc_core.c
> +++ b/drivers/remoteproc/remoteproc_core.c
> @@ -2227,6 +2227,29 @@ static int rproc_alloc_ops(struct rproc *rproc, const struct rproc_ops *ops)
> return 0;
> }
>
> +static void rproc_set_automation_flags(struct rproc *rproc)
> +{
> + struct device *dev = rproc->dev.parent;
> + struct device_node *np = dev->of_node;
> + bool core_reboot, remote_crash;
> +
> + /*
> + * When function rproc_cdev_release() or rproc_del() are called and
> + * the remote processor has been attached to, it will be detached from
> + * (rather than turned off) if "autonomous_on_core_reboot" is specified
> + * in the DT.
> + */
> + core_reboot = of_property_read_bool(np, "autonomous_on_core_reboot");
> + rproc->autonomous_on_core_reboot = core_reboot;
> +
> + /*
> + * When the remote processor crashes it will be detached from, and
> + * attached to, if "autonomous_on_remote_crash" is specified in the DT.
> + */
> + remote_crash = of_property_read_bool(np, "autonomous_on_remote_crash");
> + rproc->autonomous_on_core_reboot = core_reboot;
copy/past issue :)
rproc->autonomous_on_remote_crash = remote_crash;
Regards,
Arnaud
> +}
> +
> /**
> * rproc_alloc() - allocate a remote processor handle
> * @dev: the underlying device
> @@ -2285,6 +2308,8 @@ struct rproc *rproc_alloc(struct device *dev, const char *name,
> if (rproc_alloc_ops(rproc, ops))
> goto put_device;
>
> + rproc_set_automation_flags(rproc);
> +
> /* Assign a unique device index and name */
> rproc->index = ida_simple_get(&rproc_dev_index, 0, 0, GFP_KERNEL);
> if (rproc->index < 0) {
> diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h
> index 71d4d4873164..9a6e79ef35d7 100644
> --- a/include/linux/remoteproc.h
> +++ b/include/linux/remoteproc.h
> @@ -516,6 +516,9 @@ struct rproc_dump_segment {
> * @nb_vdev: number of vdev currently handled by rproc
> * @char_dev: character device of the rproc
> * @cdev_put_on_release: flag to indicate if remoteproc should be shutdown on @char_dev release
> + * @autonomous_on_core_reboot: true if the remote processor should be detached from
> + * (rather than turned off) when the remoteproc core
> + * goes away.
> */
> struct rproc {
> struct list_head node;
> @@ -554,6 +557,8 @@ struct rproc {
> u16 elf_machine;
> struct cdev cdev;
> bool cdev_put_on_release;
> + bool autonomous_on_core_reboot : 1,
> + autonomous_on_remote_crash : 1;
> };
>
> /**
>
