Hello:
This patch was applied to andersson/remoteproc.git (refs/heads/for-next).
On Wed, 8 Apr 2020 17:54:29 +0200 you wrote:
> dma_addr_t and phys_addr_t are distinct types and must not be
> mixed, as both the values and the size of the type may be
> different depending on what the remote device uses.
>
> In this driver the compiler warns when the two types are different:
>
> drivers/remoteproc/mtk_scp.c: In function 'scp_map_memory_region':
> drivers/remoteproc/mtk_scp.c:454:9: error: passing argument 3 of 'dma_alloc_coherent' from incompatible pointer type [-Werror=incompatible-pointer-types]
> 454 | &scp->phys_addr, GFP_KERNEL);
> | ^~~~~~~~~~~~~~~
> | |
> | phys_addr_t * {aka unsigned int *}
> In file included from drivers/remoteproc/mtk_scp.c:7:
> include/linux/dma-mapping.h:642:15: note: expected 'dma_addr_t *' {aka 'long long unsigned int *'} but argument is of type 'phys_addr_t *' {aka 'unsigned int *'}
> 642 | dma_addr_t *dma_handle, gfp_t gfp)
>
> [...]
Here is a summary with links:
- remoteproc: mtk_scp: use dma_addr_t for DMA API
https://git.kernel.org/andersson/remoteproc/c/c2781e4d9bc6d925dfc1ff833dfdaf12b69679de
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/pwbot
