On 8/29/19 2:09 PM, Bjorn Andersson wrote:
> On Thu 29 Aug 11:17 PDT 2019, Gustavo A. R. Silva wrote:
>
>> One of the more common cases of allocation size calculations is finding
>> the size of a structure that has a zero-sized array at the end, along
>> with memory for some number of elements for that array. For example:
>>
>> struct {
>> ...
>> struct intent_pair intents[];
>> } __packed * msg;
>>
>> Make use of the struct_size() helper instead of an open-coded version
>> in order to avoid any potential type mistakes.
>>
>> So, replace the following form:
>>
>> sizeof(*msg) + sizeof(struct intent_pair) * count
>>
>> with:
>>
>> struct_size(msg, intents, count)
>>
>> This code was detected with the help of Coccinelle.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
>
> Applied, thanks!
>
Awesome. :)
Thanks!
--
Gustavo
