On Mon, Apr 15, 2019 at 9:14 PM Enrico Weigelt, metux IT consult <lkml@xxxxxxxxx> wrote: > > On 12.04.19 18:00, Arnaud Pouliquen wrote: > > Hi folks, > > <snip> > > Haven't followed the whole thread, but I've got the impression that the > device is emulating an uart - if that's the case wouldn't it be better > to implement a serial driver, instead of tty directly (which IMHO should > make it also usable for serbus-based devices) ? It's more natural to implement rpmsg uart on top of tty core instead of serial layer, since: 1.Serial layer model the hardware which can just send the data one by one 2.But rpmsg could send a buffer(max 512B) in one packet On the other hand, it's very easy to support serbus by replace tty_port_register_device_attr to tty_port_register_device_attr_serdev. > > > --mtx > > -- > Enrico Weigelt, metux IT consult > Free software and Linux embedded engineering > info@xxxxxxxxx -- +49-151-27565287
