On Wed, Feb 13, 2019 at 11:20:18AM +0800, Pi-Hsun Shih wrote: > Hi, > > Thanks for the review, would address most comments in next version of patch. > > On Sat, Feb 2, 2019 at 8:17 AM Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote: > > > > Hi Pi-Hsun, > > > > a few comments inline. > > > > It's the first time I dabble into remoteproc, I don't claim to have a > > complete understanding of the driver at this point ;-) > > > > On Thu, Jan 31, 2019 at 05:31:27PM +0800, Pi-Hsun Shih wrote: > > > diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c > > > new file mode 100644 > > > index 00000000000000..920c81c3525c2a > > > --- /dev/null > > > +++ b/drivers/remoteproc/mtk_scp.c > > > + return ret; > > > + } > > > + > > > + writel(0x0, scp->reg_base + MT8183_SCP_SRAM_PDN); > > > > what is the purpose of this write? > > > > Answer from Erin: > The code needs to execute on scp’s SRAM. > We need to turn on the power of SRAM before using it. Please add a brief comment since this is not evident from the code. Thanks Matthias
