On Wed, Jan 9, 2019 at 3:55 PM Brian Norris <briannorris@xxxxxxxxxxxx> wrote: > > On Tue, Jan 08, 2019 at 09:22:30AM -0600, Rob Herring wrote: > > On Fri, Jan 4, 2019 at 7:54 PM Brian Norris <briannorris@xxxxxxxxxxxx> wrote: > > > To add to my thoughts, since I think maybe Sibi was a little unclear of > > > my thoughts: > > > > > > One of my primary concerns with the existing approach is that it's > > > basically a complete free-for-all. We should have some minimal standards > > > (enforced in code) such that our DTB can never point us at something > > > like /lib/firmware/<other-vendor>/foo.bin (or /lib/firmware/modem.mdt; > > > or lots of other bad examples). This could probably be done simply by > > > always prefixing 'qcom/' (I don't remember -- does request_firmware() > > > follow '..'? e.g., 'firmware-name = "../bar/foo.bin"'.) > > > > We can write a schema to enforce some of this: > > > > firmware-name: > > pattern: "^\w.*" > > Are DT schemas ready to use/enforce? Or would this currently just be a > suggestion? I'm out of the loop. But I guess that would be interesting. Yes, please! Initial support is in 5.0-rc. I'm not requiring new bindings to be written as schemas just yet though. We need to ring out any issues with early adopters. Rob