On Thu, Dec 20, 2018 at 10:05:55AM +0000, Patrice CHOTARD wrote: > Hi Dan > > On 12/18/18 9:16 AM, Dan Carpenter wrote: > > This is from static analysis and not from testing. It doesn't really > > make sense to talk about !BIT(0) so probably ~BIT(0) was intended. > > I had to cast it from unsigned long to unsigned int to silence a GCC > > warning. > > > > Fixes: bb6869b21478 ("Peter Griffin <peter.griffin@xxxxxxxxxx>") And oh... I put Peter's email here instead of the commit title. Sorry. I will resend if we decide the patch is required. regards, dan carpenter