On Sat 29 Sep 03:07 PDT 2018, Govind Singh wrote:
> Q6 based WiFi fw loading is supported across
> different targets, ex: IPQ8074/QCS404. In order to
> support different fw names/pas id etc, populate
> hardcoded param using driver data.
>
This patch prepares the driver for the introduction of some variation of
some of the given parameters. Please submit this patch together with the
patch introducing that new code.
> diff --git a/drivers/remoteproc/qcom_q6v5_wcss.c b/drivers/remoteproc/qcom_q6v5_wcss.c
[..]
> +static const struct wcss_data wcss_ipq8074_res_init = {
> + .firmware_name = "IPQ8074/q6_fw.mdt",
> + .crash_reason_smem = 421,
> + .pas_handover = NULL,
Please don't inherit my broken indentation from the adsp driver ;)
> +};
> +
> static const struct of_device_id q6v5_wcss_of_match[] = {
> - { .compatible = "qcom,ipq8074-wcss-pil" },
> + { .compatible = "ipq8074-wcss-pil", .data = &wcss_ipq8074_res_init },
You lost qcom, in the compatible here.
> +
Regards,
Bjorn
