On 05/29/2018 01:51 PM, Alex Elder wrote:
> On 05/29/2018 04:16 AM, Arnaud Pouliquen wrote:
> . . .
>
>>> +unroll_preparation:
>>> + list_for_each_entry_continue_reverse(subdev, &rproc->subdevs, node) {
>>> + if (subdev->unprepare)
>>> + subdev->unprepare(subdev);
>>> + }
>> Here you could call rproc_unprepare_subdevices instead of duplicating
>> the code.
>
> I thought the same thing, but it won't work because we only want to
> unprepare those devices that were successfully prepared. Here we are
> unwinding the work that was partially done; in rproc_unprepare_subdevices()
> *all* subdevices have their unprepare function called.
You right, i missed the "continue"... new for me as i never used it,
thank for teaching!
Arnaud
--
To unsubscribe from this list: send the line "unsubscribe linux-remoteproc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
