> -----Original Message----- > From: Bjorn Andersson [mailto:bjorn.andersson@xxxxxxxxxx] > Sent: Thursday, December 14, 2017 2:33 AM > To: Loic PALLARDY <loic.pallardy@xxxxxx> > Cc: ohad@xxxxxxxxxx; linux-remoteproc@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; Arnaud POULIQUEN <arnaud.pouliquen@xxxxxx>; > benjamin.gaignard@xxxxxxxxxx > Subject: Re: [PATCH v2 11/16] remoteproc: introduce > rproc_find_carveout_by_name function > > On Thu 30 Nov 08:46 PST 2017, Loic Pallardy wrote: > > +struct rproc_mem_entry * > > +rproc_find_carveout_by_name(struct rproc *rproc, char *name) > > In almost all cases after this patch you have to do a snprintf(), so it > would be better to make this function format the name based on a format > string and variable arguments. Good point /Loic > > > +{ > > + struct rproc_mem_entry *carveout, *mem = NULL; > > + > > + if (!name) > > + return NULL; > > + > > + list_for_each_entry(carveout, &rproc->carveouts, node) { > > + /* Compare carveout and requested names */ > > + if (!strcmp(carveout->name, name)) { > > + mem = carveout; > > + break; > > + } > > + } > > + > > + return mem; > > +} > > + > > Regards, > Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-remoteproc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
