Hi Henri, On 06/02/2017 06:35 AM, Henri Roosen wrote: > A device might not have an ops structure registered. This The rpmsg devices are registered from the respective backends, which are supposed to plug in their ops. What is the scenario where you think these ops might not be populated? We ought to check for NULL ops in rpmsg_register_device in fact to make sure an ops pointer is supplied. regards Suman > patch fixes a null-prt dereference by checking ops before dereferencing > it. > > Signed-off-by: Henri Roosen <henri.roosen@xxxxxxxxxxxxx> > --- > drivers/rpmsg/rpmsg_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c > index 600f5f9..0c48452 100644 > --- a/drivers/rpmsg/rpmsg_core.c > +++ b/drivers/rpmsg/rpmsg_core.c > @@ -429,7 +429,7 @@ static int rpmsg_dev_probe(struct device *dev) > goto out; > } > > - if (rpdev->ops->announce_create) > + if (rpdev->ops && rpdev->ops->announce_create) > err = rpdev->ops->announce_create(rpdev); > out: > return err; > -- To unsubscribe from this list: send the line "unsubscribe linux-remoteproc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
