On Fri 26 May 06:01 PDT 2017, Dwivedi, Avaneesh Kumar (avani) wrote: > On 5/26/2017 11:33 AM, Bjorn Andersson wrote: > > On Tue 16 May 11:01 PDT 2017, Avaneesh Kumar Dwivedi wrote: [..] > > > diff --git a/include/linux/qcom_scm.h b/include/linux/qcom_scm.h [..] > > > +#define QCOM_SCM_VMID_HLOS 0x3 > > > +#define QCOM_SCM_VMID_MSS_MSA 0xF > > > +#define QCOM_SCM_PERM_READ 0x4 > > > +#define QCOM_SCM_PERM_WRITE 0x2 > > > +#define QCOM_SCM_PERM_EXEC 0x1 > > > +#define QCOM_SCM_PERM_RW (QCOM_SCM_PERM_READ | QCOM_SCM_PERM_WRITE) > > Add QCOM_SCM_PERM_RWX, as this looks fairly common as well. > You mean change name as QCOM_SCM_PERM_RWX instead of QCOM_SCM_PERM_RW ? OK. Provide both RW and RWX, as already in the first client of this API you're using both. Thanks, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-remoteproc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html