On 12/09/2016 07:00 AM, Bjorn Andersson wrote:
On Wed 07 Dec 00:42 PST 2016, loic pallardy wrote:
On 12/06/2016 06:40 PM, Bjorn Andersson wrote:
On Mon 05 Dec 00:32 PST 2016, loic pallardy wrote:
[..]
And as I said, we use the "id" when creating the device to match with
drivers, so I don't see how probing would work with it introduced.
Change has been introduce here:
4dffed5b3ac796bcaf040ca1f64e650f9263363e rpmsg: Name rpmsg devices based on
channel id
- dev_set_name(&rpdev->dev, "rpmsg%d", rpmsg_dev_index++);
+ dev_set_name(&rpdev->dev, "%s:%s",
+ dev_name(dev->parent), rpdev->id.name);
Ok, that makes much more sense.
Before name was not explicit but unique.
Now name is clear but not unique. If 2 identical services are announced on
the same rpmsg link, second will failed.
Instance number is needed to make it unique.
How about we just add rpdev->src and rpdev->dst in the name as well?
dev_set_name(&rpdev->dev, "%s.%d.%d.%s",
dev_name(dev->parent),
rpdev->src,
rpdev->dst,
rpdev->id.name);
As far as I can see this would be unique over all possible
configurations that we support.
Yes that's true I selected only dst, but better to have complete pair
src-dst?
I'll send a V2.
Thanks
Loic
Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-remoteproc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
