On Sun 21 Aug 07:39 PDT 2016, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
>
> In case of error, the function devm_ioremap_resource() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check should
> be replaced with IS_ERR().
>
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
Thanks Wei, applied to rproc-next.
Regards,
Bjorn
> ---
> drivers/remoteproc/qcom_wcnss.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/remoteproc/qcom_wcnss.c b/drivers/remoteproc/qcom_wcnss.c
> index 14c4585..1917de7 100644
> --- a/drivers/remoteproc/qcom_wcnss.c
> +++ b/drivers/remoteproc/qcom_wcnss.c
> @@ -528,8 +528,8 @@ static int wcnss_probe(struct platform_device *pdev)
>
> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "pmu");
> mmio = devm_ioremap_resource(&pdev->dev, res);
> - if (!mmio) {
> - ret = -ENOMEM;
> + if (IS_ERR(mmio)) {
> + ret = PTR_ERR(mmio);
> goto free_rproc;
> };
>
--
To unsubscribe from this list: send the line "unsubscribe linux-remoteproc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
