Hello Thanks for your review, I will fix all your reports for next version. On 12/08/2016 21:06, Bjorn Andersson wrote: > On Fri 12 Aug 04:46 PDT 2016, LABBE Corentin wrote: > >> Add hwspinlock support for the Allwinner Hardware Spinlock device >> present on the A83T, H3 and A64 SoCs. >> >> This Hardware Spinlock device provides hardware assistance >> for synchronization between the multiple processors in the system. >> > [..] >> + goto clk_fail; >> + } >> + >> + dev_info(&pdev->dev, "Sun8i hwspinlock driver loaded with %d locks\n", >> + priv->num_locks); > > Please don't advertise the driver on success. > I was doing that because datasheet specify only 32 slot, but later a register give a possibility of more slots. Perhaps its better to advertise only for uncommon hardware (slot > 32) ? Regards LABBE Corentin -- To unsubscribe from this list: send the line "unsubscribe linux-remoteproc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
