From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx> There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx> --- drivers/remoteproc/qcom_q6v5_pil.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/remoteproc/qcom_q6v5_pil.c b/drivers/remoteproc/qcom_q6v5_pil.c index 4913ec6..790ec6f 100644 --- a/drivers/remoteproc/qcom_q6v5_pil.c +++ b/drivers/remoteproc/qcom_q6v5_pil.c @@ -679,17 +679,13 @@ static int q6v5_init_mem(struct q6v5 *qproc, struct platform_device *pdev) res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "qdsp6"); qproc->reg_base = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(qproc->reg_base)) { - dev_err(qproc->dev, "failed to get qdsp6_base\n"); + if (IS_ERR(qproc->reg_base)) return PTR_ERR(qproc->reg_base); - } res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "rmb"); qproc->rmb_base = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(qproc->rmb_base)) { - dev_err(qproc->dev, "failed to get rmb_base\n"); + if (IS_ERR(qproc->rmb_base)) return PTR_ERR(qproc->rmb_base); - } ret = of_parse_phandle_with_fixed_args(pdev->dev.of_node, "qcom,halt-regs", 3, 0, &args); -- To unsubscribe from this list: send the line "unsubscribe linux-remoteproc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html