On Wed, Feb 10, 2021 at 06:12:58AM +0000, Saeed Mahameed wrote:
> On Fri, 2021-02-05 at 15:45 +0300, Dan Carpenter wrote:
> > Hello Saeed Mahameed and Feras Daoud,
> >
>
> Hi Dan, thanks for the report, adding Roi the owner of this change.
>
> > I'm not exactly sure if I should blame commit c4d7eb57687f:
> > "net/mxl5e:
> > Add change profile method" fomr Mar 22, 2020 or commit 182570b26223
> > ("net/mlx5e: Gather common netdev init/cleanup functionality in one
> > place") from Oct 2, 2018.
> >
> > drivers/net/ethernet/mellanox/mlx5/core/en_main.c:5658
> > mlx5e_netdev_change_profile() warn: 'priv->htb.qos_sq_stats' double
> > freed
> > drivers/net/ethernet/mellanox/mlx5/core/en_main.c:5658
> > mlx5e_netdev_change_profile() warn: 'priv->scratchpad.cpumask' double
> > freed
> > drivers/net/ethernet/mellanox/mlx5/core/en_main.c:5789 mlx5e_probe()
> > warn: 'priv->htb.qos_sq_stats' double freed
> > drivers/net/ethernet/mellanox/mlx5/core/en_main.c:5789 mlx5e_probe()
> > warn: 'priv->scratchpad.cpumask' double freed
> > drivers/net/ethernet/mellanox/mlx5/core/en_main.c:5802 mlx5e_remove()
> > warn: 'priv->htb.qos_sq_stats' double freed
> > drivers/net/ethernet/mellanox/mlx5/core/en_main.c:5802 mlx5e_remove()
> > warn: 'priv->scratchpad.cpumask' double freed
> > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:1317
> > mlx5e_vport_rep_unload() warn: 'priv->htb.qos_sq_stats' double freed
> > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:1317
> > mlx5e_vport_rep_unload() warn: 'priv->scratchpad.cpumask' double
> > freed
>
> If I may ask,
> What is this report ? Coverity ? static checker ? or runtime checks ?
>
This is a Smatch check but you have to have the cross function database
built. And the code is from 2018 so something must have improved in how
the cross function DB is working recently for it to generate this
warning... I'm not sure exactly what I improved or if I have pushed
that change yet...
regards,
dan carpenter
