> Subject: Re: [PATCH 20/22] RDMA/irdma: Add ABI definitions > > On Sat, Jan 30, 2021 at 01:18:36AM +0000, Saleem, Shiraz wrote: > > > Subject: Re: [PATCH 20/22] RDMA/irdma: Add ABI definitions > > > > > > On Fri, Jan 22, 2021 at 05:48:25PM -0600, Shiraz Saleem wrote: > > > > From: Mustafa Ismail <mustafa.ismail@xxxxxxxxx> > > > > > > > > Add ABI definitions for irdma. > > > > > > > > Signed-off-by: Mustafa Ismail <mustafa.ismail@xxxxxxxxx> > > > > Signed-off-by: Shiraz Saleem <shiraz.saleem@xxxxxxxxx> > > > > include/uapi/rdma/irdma-abi.h | 140 > > > > ++++++++++++++++++++++++++++++++++++++++++ > > > > 1 file changed, 140 insertions(+) create mode 100644 > > > > include/uapi/rdma/irdma-abi.h > > > > > > > > diff --git a/include/uapi/rdma/irdma-abi.h > > > > b/include/uapi/rdma/irdma-abi.h new file mode 100644 index > > > > 0000000..d9c8ce1 > > > > +++ b/include/uapi/rdma/irdma-abi.h > > > > @@ -0,0 +1,140 @@ > > > > +/* SPDX-License-Identifier: (GPL-2.0 WITH Linux-syscall-note) OR > > > > +Linux-OpenIB) */ > > > > +/* > > > > + * Copyright (c) 2006 - 2021 Intel Corporation. All rights reserved. > > > > + * Copyright (c) 2005 Topspin Communications. All rights reserved. > > > > + * Copyright (c) 2005 Cisco Systems. All rights reserved. > > > > + * Copyright (c) 2005 Open Grid Computing, Inc. All rights reserved. > > > > + */ > > > > + > > > > +#ifndef IRDMA_ABI_H > > > > +#define IRDMA_ABI_H > > > > + > > > > +#include <linux/types.h> > > > > + > > > > +/* irdma must support legacy GEN_1 i40iw kernel > > > > + * and user-space whose last ABI ver is 5 */ #define > > > > +IRDMA_ABI_VER 6 > > > > > > I don't want to see this value increase, either this is ABI > > > compatible with i40iw or it is not and should be a new driver_id. > > > > I am not sure I understand how it's possible without a ver. bump. > > We support user-space libirdma with this driver as well as libi40iw. > > Well, start by not making gratuitous changes to the structure layouts and then ask > how to handle what you have left over. > Took a while but following now. We ll PoC and see how this shapes out. Thanks!
