On Thu, Jan 28, 2021 at 11:47:53AM -0600, Bob Pearson wrote: > [2] > Replaced unnecessary if(skb) by a comment. > > [1] version log at the end after dashes > rxe_rcv_mcast_pkt() in rxe_recv.c can leak SKBs in error path > code. The loop over the QPs attached to a multicast group > creates new cloned SKBs for all but the last QP in the list > and passes the SKB and its clones to rxe_rcv_pkt() for further > processing. Any QPs that do not pass some checks are skipped. > If the last QP in the list fails the tests the SKB is leaked. > This patch checks if the SKB for the last QP was used and if > not frees it. Also removes a redundant loop invariant assignment. > > Fixes: 8700e3e7c4857 ("Soft RoCE driver") > Fixes: 71abf20b28ff8 ("RDMA/rxe: Handle skb_clone() failure in rxe_recv.c") Applied to for-next, thanks Jason