On Tue, Feb 2, 2021 at 10:08 AM Yishai Hadas <yishaih@xxxxxxxxxx> wrote: > Implement devlink port function commands to enable / disable roce. > This is used to control the roce device capabilities. [..] > +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h > @@ -122,8 +122,9 @@ struct mlx5_vport_info { > int link_state; > u32 min_rate; > u32 max_rate; > - bool spoofchk; > - bool trusted; > + u8 spoofchk: 1; > + u8 trusted: 1; > + u8 roce_enabled: 1; > }; This struct has attributes which have e-switch vport affiliation where roce enable/disable is a property of the vhca function-over-the-e-wire -- it's that we do something specific in the e-switching to enforce - sounds like a problematic location to land the bit..