On Tue, Feb 02, 2021 at 04:01:24PM +0000, Parav Pandit wrote: > > > > From: Jason Gunthorpe <jgg@xxxxxxxxxx> > > Sent: Tuesday, February 2, 2021 8:51 PM > > > > > > xa_lock(&imr->implicit_children); > > > - /* > > > - * Once the store to either xarray completes any error unwind has to > > > - * use synchronize_srcu(). Avoid this with xa_reserve() > > > - */ > > > > It is not wrong to remove this comment, but why is it in this patch? > > > > Jason > > Hi Leon, > Can you please check your tree, how this hunk got merged in this patch? > In my internal gerrit submission, I do not have this hunk. > May be somehow it got here as part of Yishai's ODP srcu patches? This explains why I didn't find this hunk in Yishai's patch. https://lore.kernel.org/linux-rdma/20210128064812.1921519-1-leon@xxxxxxxxxx Thanks.
