On Fri, Jan 22, 2021 at 05:48:23PM -0600, Shiraz Saleem wrote: > From: Mustafa Ismail <mustafa.ismail@xxxxxxxxx> > > Add miscellaneous utility functions and headers. > > Signed-off-by: Mustafa Ismail <mustafa.ismail@xxxxxxxxx> > Signed-off-by: Shiraz Saleem <shiraz.saleem@xxxxxxxxx> > drivers/infiniband/hw/irdma/osdep.h | 99 ++ > drivers/infiniband/hw/irdma/protos.h | 118 ++ > drivers/infiniband/hw/irdma/status.h | 70 + > drivers/infiniband/hw/irdma/utils.c | 2680 ++++++++++++++++++++++++++++++++++ > 4 files changed, 2967 insertions(+) > create mode 100644 drivers/infiniband/hw/irdma/osdep.h > create mode 100644 drivers/infiniband/hw/irdma/protos.h > create mode 100644 drivers/infiniband/hw/irdma/status.h > create mode 100644 drivers/infiniband/hw/irdma/utils.c > > diff --git a/drivers/infiniband/hw/irdma/osdep.h b/drivers/infiniband/hw/irdma/osdep.h > new file mode 100644 > index 0000000..10e2e02 > +++ b/drivers/infiniband/hw/irdma/osdep.h > @@ -0,0 +1,99 @@ > +/* SPDX-License-Identifier: GPL-2.0 or Linux-OpenIB */ > +/* Copyright (c) 2015 - 2021 Intel Corporation */ > +#ifndef IRDMA_OSDEP_H > +#define IRDMA_OSDEP_H > + > +#include <linux/pci.h> > +#include <crypto/hash.h> > +#include <rdma/ib_verbs.h> > + > +#define STATS_TIMER_DELAY 60000 > + > +#define idev_to_dev(ptr) (&((ptr)->hw->pcidev->dev)) > +#define ihw_to_dev(hw) (&(hw)->pcidev->dev) Try to avoid defines like this, it looses the typing information of the arguments. These should be static inline functions Jason
