Re: [PATCH for-next 2/3] RDMA/hns: Optimize the MR registration process

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Weihang,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on rdma/for-next]
[also build test WARNING on v5.11-rc4 next-20210121]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Weihang-Li/RDMA-hns-Refactor-codes-about-memory/20210121-215817
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next
config: sparc-allyesconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/9ff47c3f8e6b778282c3bc9d4fb65ce835bdd83c
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Weihang-Li/RDMA-hns-Refactor-codes-about-memory/20210121-215817
        git checkout 9ff47c3f8e6b778282c3bc9d4fb65ce835bdd83c
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/infiniband/hw/hns/hns_roce_mr.c:140:6: warning: no previous prototype for 'hns_roce_mr_free' [-Wmissing-prototypes]
     140 | void hns_roce_mr_free(struct hns_roce_dev *hr_dev, struct hns_roce_mr *mr)
         |      ^~~~~~~~~~~~~~~~


vim +/hns_roce_mr_free +140 drivers/infiniband/hw/hns/hns_roce_mr.c

   139	
 > 140	void hns_roce_mr_free(struct hns_roce_dev *hr_dev, struct hns_roce_mr *mr)
   141	{
   142		struct ib_device *ibdev = &hr_dev->ib_dev;
   143		int ret;
   144	
   145		if (mr->enabled) {
   146			ret = hns_roce_hw_destroy_mpt(hr_dev, NULL,
   147						      key_to_hw_index(mr->key) &
   148						      (hr_dev->caps.num_mtpts - 1));
   149			if (ret)
   150				ibdev_warn(ibdev, "failed to destroy mpt, ret = %d.\n",
   151					   ret);
   152		}
   153	
   154		free_mr_pbl(hr_dev, mr);
   155		free_mr_key(hr_dev, mr);
   156	}
   157	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux