On Tue, Jan 19, 2021 at 03:19:15PM +0200, Gal Pressman wrote: > On 19/01/2021 13:58, Leon Romanovsky wrote: > > On Tue, Jan 19, 2021 at 11:10:59AM +0200, Gal Pressman wrote: > >> On 19/01/2021 10:46, Leon Romanovsky wrote: > >>> On Tue, Jan 19, 2021 at 09:17:14AM +0200, Gal Pressman wrote: > >>>> On 05/01/2021 12:43, Gal Pressman wrote: > >>>>> The following two patches add the userspace version to the host > >>>>> information struct reported to the device, used for debugging and > >>>>> troubleshooting purposes. > >>>>> > >>>>> PR was sent: > >>>>> https://github.com/linux-rdma/rdma-core/pull/918 > >>>>> > >>>>> Thanks, > >>>>> Gal > >>>> > >>>> Anything stopping this series from being merged? > >>> > >>> It is unclear when this forwarding of non-verbs data to the FW will stop. > >> > >> This was already discussed in the PR. Not everything should be passed through > >> this interface, there should be a limit and it should be examined per case. > >> rdma-core version is clearly related to an RDMA device. > > > > "Clearly or not" - it depends on the observer. > > > >> > >> BTW, if you have any concerns about a patch you can state them, you don't have > >> to ignore it and wait for the submitter to ask what's wrong.. > > > > Didn't you mistake me with anyone else? > > No, you decided to answer my original question :). > > > I'm reviewer in the kernel exactly like you and it gives me nice thing - ignore patches. > > Don't get me wrong, your review is very appreciated, but this series is 20 LOC > which you already reviewed two weeks ago, and I replied to all comments. > Ignoring patches is fine, but please don't review, ignore and wait for the last > minute to say they shouldn't be merged. Sorry, but it is impossible to get it right. I gave you hint WHY it takes so long, it is not review/ack/nack or anything like this. Thanks
