On Tue, Jan 19, 2021 at 02:40:52PM +0200, Mohamed._. Heib wrote: > Hi, > As far as i remember the traffic still can be encapsulated over the > vlan interface with vlan tag > by specifying the vlan interface gid index that mapped to the vlan ip > on the vlan parent interface gids table. > And by removing the vlan related functionality on rxe (commit: > b2d2440430c0) the rxe still can send traffic via vlan interface > but can't receive from vlan interface and that will break the vlan > functionality on rxe so i think you need keep the vlan related code on > rxe. That may be, but the code here is still wrong. Incoming packets are supposed to be matched to the gid table, which specifies the allowed vlans, it can't just be taken raw from the skb like this. If someone wants to add vlan support to rxe it needs to be done right, currently it doesn't support vlan. Jason
