> From: Jakub Kicinski <kuba@xxxxxxxxxx>
> Sent: Thursday, January 14, 2021 11:52 PM
>
> On Thu, 14 Jan 2021 17:53:09 +0000 Parav Pandit wrote:
> > > From: Jakub Kicinski <kuba@xxxxxxxxxx>
> > > Sent: Thursday, January 14, 2021 11:13 PM
> > >
> > > On Wed, 13 Jan 2021 11:27:18 -0800 Saeed Mahameed wrote:
> > > > /**
> > > > * struct devlink_port_attrs - devlink port object
> > > > * @flavour: flavour of the port
> > > > @@ -114,6 +126,7 @@ struct devlink_port_attrs {
> > > > struct devlink_port_phys_attrs phys;
> > > > struct devlink_port_pci_pf_attrs pci_pf;
> > > > struct devlink_port_pci_vf_attrs pci_vf;
> > > > + struct devlink_port_pci_sf_attrs pci_sf;
> > > > };
> > > > };
> > >
> > > include/net/devlink.h:131: warning: Function parameter or member
> 'pci_sf'
> > > not described in 'devlink_port_attrs'
> > Wasn't reported till v5.
> > Can you please share, which script catches this? So that I can run next time
> early.
>
> This is just scripts/kernel-doc from the tree.
>
Ok. Got it. This is helpful.
Will wait to gather other comments.
Otherwise better to do bulk conversion for all the below one in include/net/devlink.h apart from this SF one.
./scripts/kernel-doc -none include/net/devlink.h
include/net/devlink.h:217: warning: Function parameter or member 'field_id' not described in 'devlink_dpipe_match'
include/net/devlink.h:232: warning: Function parameter or member 'field_id' not described in 'devlink_dpipe_action'
include/net/devlink.h:275: warning: Function parameter or member 'match_values_count' not described in 'devlink_dpipe_entry'
include/net/devlink.h:320: warning: Function parameter or member 'list' not described in 'devlink_dpipe_table'
include/net/devlink.h:339: warning: Function parameter or member 'actions_dump' not described in 'devlink_dpipe_table_ops'
include/net/devlink.h:339: warning: Function parameter or member 'matches_dump' not described in 'devlink_dpipe_table_ops'
include/net/devlink.h:339: warning: Function parameter or member 'entries_dump' not described in 'devlink_dpipe_table_ops'
include/net/devlink.h:339: warning: Function parameter or member 'counters_set_update' not described in 'devlink_dpipe_table_ops'
include/net/devlink.h:339: warning: Function parameter or member 'size_get' not described in 'devlink_dpipe_table_ops'
include/net/devlink.h:349: warning: Function parameter or member 'headers' not described in 'devlink_dpipe_headers'
include/net/devlink.h:349: warning: Function parameter or member 'headers_count' not described in 'devlink_dpipe_headers'
include/net/devlink.h:363: warning: Function parameter or member 'unit' not described in 'devlink_resource_size_params'
include/net/devlink.h:404: warning: Function parameter or member 'occ_get' not described in 'devlink_resource'
include/net/devlink.h:404: warning: Function parameter or member 'occ_get_priv' not described in 'devlink_resource'
include/net/devlink.h:477: warning: Function parameter or member 'id' not described in 'devlink_param'
include/net/devlink.h:606: warning: Function parameter or member 'overwrite_mask' not described in 'devlink_flash_update_params'
> All the tests are here:
>
> https://github.com/kuba-moo/nipa/blob/master/tests/
