On 1/14/2021 2:49 PM, Jason Gunthorpe wrote:
On Thu, Jan 14, 2021 at 09:29:38AM +0200, Leon Romanovsky wrote:
On Wed, Jan 13, 2021 at 04:08:29PM -0800, Sagi Grimberg wrote:
Use if/else clause instead of "condition ? val1 : val2" to make the code
cleaner and simpler.
Not sure what is cleaner and simpler for a simple condition, but I don't
mind either way...
Agree, probably even more cleaner variant will be:
device->pi_capable = !!(ib_dev->attrs.device_cap_flags & IB_DEVICE_INTEGRITY_HANDOVER);
Gah, !! is rarely a sign of something good..
can we take the series as-is ?
We have enough Acks and eyes on these minor cleanups.
Jason
