On 12/15/20 10:15 PM, Parav Pandit wrote: >>> + * enum devlink_port_function_opstate - indicates operational state >>> + of port function >>> + * @DEVLINK_PORT_FUNCTION_OPSTATE_ATTACHED: Driver is attached >> to the >>> + function of port, >> This name definitely needs to be shortened. >> > DEVLINK_PORT_FUNCTION_OPS_ATTACHED > Or > DEVLINK_PF_OPS_ATTACHED > > PF - port function > The devlink attribute names need to start using established short names to find that balance between readability and ridiculously long names. In this case PF for networking has an established link to SRIOV 'physical function'. FUNCTION can be written as FCN. ATTACHED can be shortened to ATTCH. So in this case DEVLINK_PORT_FUNCTION_OPSTATE_ATTACHED (38 chars) drops to DEVLINK_PORT_FCN_OPSTATE_ATTCH (30 chars). That is a step in the right direction.
